Move the Py_DECREF(x) after the error: label so that we don't leak x

gvanrossum · gvanrossum · commit 7c5540420737 · 2000-09-01T15:35:12.000Z
when PyDict_SetItemString() fails.
diff --git a/Modules/linuxaudiodev.c b/Modules/linuxaudiodev.c
@@ -440,8 +440,8 @@ initlinuxaudiodev(void)
     x = PyInt_FromLong((long) AFMT_S16_LE);
     if (x == NULL || PyDict_SetItemString(d, "AFMT_S16_LE", x) < 0)
         goto error;
-    Py_DECREF(x);
 
   error:
+    Py_DECREF(x);
     return;
 }

Original file line number	Diff line number	Diff line change
`@@ -440,8 +440,8 @@ initlinuxaudiodev(void)`
`440`	`440`	`x = PyInt_FromLong((long) AFMT_S16_LE);`
`441`	`441`	`if (x == NULL \|\| PyDict_SetItemString(d, "AFMT_S16_LE", x) < 0)`
`442`	`442`	`goto error;`
`443`		`- Py_DECREF(x);`
`444`	`443`
`445`	`444`	`error:`
	`445`	`+ Py_DECREF(x);`
`446`	`446`	`return;`
`447`	`447`	`}`