The previous fix was still broken; the Py_END_ALLOW_THREADS macro was

gvanrossum · gvanrossum · commit 80c7bcf667b4 · 1998-08-29T16:03:27.000Z
never executed because of a return statement.  Sigh.
diff --git a/Parser/myreadline.c b/Parser/myreadline.c
@@ -140,10 +140,12 @@ char *
 PyOS_Readline(prompt)
 	char *prompt;
 {
+	char *rv;
 	if (PyOS_ReadlineFunctionPointer == NULL) {
 			PyOS_ReadlineFunctionPointer = PyOS_StdioReadline;
 	}
 	Py_BEGIN_ALLOW_THREADS
-	return (*PyOS_ReadlineFunctionPointer)(prompt);
+	rv = (*PyOS_ReadlineFunctionPointer)(prompt);
 	Py_END_ALLOW_THREADS
+	return rv;
 }

Original file line number	Diff line number	Diff line change
`@@ -140,10 +140,12 @@ char *`
`140`	`140`	`PyOS_Readline(prompt)`
`141`	`141`	`char *prompt;`
`142`	`142`	`{`
	`143`	`+ char *rv;`
`143`	`144`	`if (PyOS_ReadlineFunctionPointer == NULL) {`
`144`	`145`	`PyOS_ReadlineFunctionPointer = PyOS_StdioReadline;`
`145`	`146`	`}`
`146`	`147`	`Py_BEGIN_ALLOW_THREADS`
`147`		`- return (*PyOS_ReadlineFunctionPointer)(prompt);`
	`148`	`+ rv = (*PyOS_ReadlineFunctionPointer)(prompt);`
`148`	`149`	`Py_END_ALLOW_THREADS`
	`150`	`+ return rv;`
`149`	`151`	`}`