Inform the cycle-detector that the a weakref object no longer needs to be

freddrake · freddrake · commit 82f1480d63a4 · 2001-03-22T18:05:30.000Z
tracked as soon as it is clear; this can decrease the number of roots for
the cycle detector sooner rather than later in applications which hold on
to weak references beyond the time of the invalidation.
diff --git a/Modules/_weakref.c b/Modules/_weakref.c
@@ -59,6 +59,7 @@ clear_weakref(PyWeakReference *self)
     if (self->wr_object != Py_None) {
         PyWeakReference **list = GET_WEAKREFS_LISTPTR(self->wr_object);
 
+        PyObject_GC_Fini((PyObject *)self);
         if (*list == self)
             *list = self->wr_next;
         self->wr_object = Py_None;
@@ -78,7 +79,6 @@ static void
 weakref_dealloc(PyWeakReference *self)
 {
     clear_weakref(self);
-    PyObject_GC_Fini((PyObject *)self);
     self->wr_next = free_list;
     free_list = self;
 }

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ clear_weakref(PyWeakReference *self)`
`59`	`59`	`if (self->wr_object != Py_None) {`
`60`	`60`	`PyWeakReference **list = GET_WEAKREFS_LISTPTR(self->wr_object);`
`61`	`61`
	`62`	`+ PyObject_GC_Fini((PyObject *)self);`
`62`	`63`	`if (*list == self)`
`63`	`64`	`*list = self->wr_next;`
`64`	`65`	`self->wr_object = Py_None;`
`@@ -78,7 +79,6 @@ static void`
`78`	`79`	`weakref_dealloc(PyWeakReference *self)`
`79`	`80`	`{`
`80`	`81`	`clear_weakref(self);`
`81`		`- PyObject_GC_Fini((PyObject *)self);`
`82`	`82`	`self->wr_next = free_list;`
`83`	`83`	`free_list = self;`
`84`	`84`	`}`