gh-117953: Fix Refleaks Introduced by gh-118194 (gh-118250)

ericsnowcurrently · web-flow · commit 85ec1c2dc67c · 2024-04-24T21:23:45.000Z
A couple of refleaks slipped through in gh-118194. This takes care of them. (AKA _Py_ext_module_loader_info_init() does not steal references.)
diff --git a/Python/importdl.c b/Python/importdl.c
@@ -169,9 +169,13 @@ _Py_ext_module_loader_info_init_from_spec(
     }
     PyObject *filename = PyObject_GetAttrString(spec, "origin");
     if (filename == NULL) {
+        Py_DECREF(name);
         return -1;
     }
-    return _Py_ext_module_loader_info_init(p_info, name, filename);
+    int err = _Py_ext_module_loader_info_init(p_info, name, filename);
+    Py_DECREF(name);
+    Py_DECREF(filename);
+    return err;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -169,9 +169,13 @@ _Py_ext_module_loader_info_init_from_spec(`
`169`	`169`	`}`
`170`	`170`	`PyObject *filename = PyObject_GetAttrString(spec, "origin");`
`171`	`171`	`if (filename == NULL) {`
	`172`	`+ Py_DECREF(name);`
`172`	`173`	`return -1;`
`173`	`174`	`}`
`174`		`- return _Py_ext_module_loader_info_init(p_info, name, filename);`
	`175`	`+ int err = _Py_ext_module_loader_info_init(p_info, name, filename);`
	`176`	`+ Py_DECREF(name);`
	`177`	`+ Py_DECREF(filename);`
	`178`	`+ return err;`
`175`	`179`	`}`
`176`	`180`
`177`	`181`