#11062: Fix universal newline support in Babyl._install_message()

akheron · akheron · commit 88614948c08a · 2012-08-16T07:27:01.000+03:00
When adding a message from a binary file, \r\n was translated to
\r\r\n in the message body.
diff --git a/Lib/mailbox.py b/Lib/mailbox.py
@@ -1450,10 +1450,17 @@ def _install_message(self, message):
                     else:
                         break
             while True:
-                buffer = message.read(4096)     # Buffer size is arbitrary.
-                if not buffer:
+                line = message.readline()
+                if not line:
                     break
-                self._file.write(buffer.replace(b'\n', linesep))
+                # Universal newline support.
+                if line.endswith(b'\r\n'):
+                    line = line[:-2] + linesep
+                elif line.endswith(b'\r'):
+                    line = line[:-1] + linesep
+                elif line.endswith(b'\n'):
+                    line = line[:-1] + linesep
+                self._file.write(line)
         else:
             raise TypeError('Invalid message type: %s' % type(message))
         stop = self._file.tell()
