bpo-36745: Fix a possible reference leak in PyObject_SetAttr() (GH-12993)

miss-islington · ZackerySpytz · web-flow · commit 896c6357f326 · 2019-04-28T06:17:40.000-07:00
https://bugs.python.org/issue36745 (cherry picked from commit e0dcb85) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/Objects/object.c b/Objects/object.c
@@ -1017,8 +1017,10 @@ PyObject_SetAttr(PyObject *v, PyObject *name, PyObject *value)
     }
     if (tp->tp_setattr != NULL) {
         const char *name_str = PyUnicode_AsUTF8(name);
-        if (name_str == NULL)
+        if (name_str == NULL) {
+            Py_DECREF(name);
             return -1;
+        }
         err = (*tp->tp_setattr)(v, (char *)name_str, value);
         Py_DECREF(name);
         return err;
