Fix SF bug [ #445474 ] warn about import * inside functions

jeremyhylton · jeremyhylton · commit 8a6f29530388 · 2001-08-06T19:45:40.000Z
Reported by the Man himself.
diff --git a/Python/compile.c b/Python/compile.c
@@ -5294,6 +5294,11 @@ symtable_import(struct symtable *st, node *n)
 			}
 		}
 		if (TYPE(CHILD(n, 3)) == STAR) {
+			if (st->st_cur->ste_type != TYPE_MODULE) {
+				symtable_warn(st,
+				      "import * not allowed inside function");
+				return;
+			}
 			st->st_cur->ste_optimized |= OPT_IMPORT_STAR;
 			st->st_cur->ste_opt_lineno = n->n_lineno;
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -5294,6 +5294,11 @@ symtable_import(struct symtable st, node n)`
`5294`	`5294`	`}`
`5295`	`5295`	`}`
`5296`	`5296`	`if (TYPE(CHILD(n, 3)) == STAR) {`
	`5297`	`+ if (st->st_cur->ste_type != TYPE_MODULE) {`
	`5298`	`+ symtable_warn(st,`
	`5299`	`+ "import * not allowed inside function");`
	`5300`	`+ return;`
	`5301`	`+ }`
`5297`	`5302`	`st->st_cur->ste_optimized \|= OPT_IMPORT_STAR;`
`5298`	`5303`	`st->st_cur->ste_opt_lineno = n->n_lineno;`
`5299`	`5304`	`} else {`