Issue #22351: Fix test_nntplib if the ssl module is missing

vstinner · vstinner · commit 8c9bba07d40f · 2015-04-03T11:06:40.000+02:00
@unittest.skipUnless(ssl, '...') doesn't work because the class body uses the
nntplib.NNTP_SSL attribute which doesn't exist.
diff --git a/Lib/test/test_nntplib.py b/Lib/test/test_nntplib.py
@@ -1509,15 +1509,16 @@ def handle_AUTHINFO(self, *args):
             Handler, nntplib.NNTPPermanentError, authinfo_response,
             login, password)
 
-@unittest.skipUnless(ssl, 'requires SSL support')
-class MockSslTests(MockSocketTests):
-    class nntp_class(nntplib.NNTP_SSL):
-        def __init__(self, *pos, **kw):
-            class bypass_context:
-                """Bypass encryption and actual SSL module"""
-                def wrap_socket(sock, **args):
-                    return sock
-            return super().__init__(*pos, ssl_context=bypass_context, **kw)
+if ssl is not None:
+    class MockSslTests(MockSocketTests):
+        class nntp_class(nntplib.NNTP_SSL):
+            def __init__(self, *pos, **kw):
+                class bypass_context:
+                    """Bypass encryption and actual SSL module"""
+                    def wrap_socket(sock, **args):
+                        return sock
+                return super().__init__(*pos, ssl_context=bypass_context, **kw)
+
 
 if __name__ == "__main__":
     unittest.main()
