gh-121137: Add missing Py_DECREF calls for ADDITEMS opcode of _pickle.c (#121136)

Legoclones · web-flow · commit 92893fd8dc80 · 2024-06-28T14:43:45.000-07:00
PyObject_GetAttr returns a new reference, but this reference is never decremented using Py_DECREF, so Py_DECREF calls to this referece are added
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -6524,11 +6524,13 @@ load_additems(PickleState *state, UnpicklerObject *self)
             if (result == NULL) {
                 Pdata_clear(self->stack, i + 1);
                 Py_SET_SIZE(self->stack, mark);
+                Py_DECREF(add_func);
                 return -1;
             }
             Py_DECREF(result);
         }
         Py_SET_SIZE(self->stack, mark);
+        Py_DECREF(add_func);
     }
 
     return 0;

Original file line number	Diff line number	Diff line change
`@@ -6524,11 +6524,13 @@ load_additems(PickleState state, UnpicklerObject self)`
`6524`	`6524`	`if (result == NULL) {`
`6525`	`6525`	`Pdata_clear(self->stack, i + 1);`
`6526`	`6526`	`Py_SET_SIZE(self->stack, mark);`
	`6527`	`+ Py_DECREF(add_func);`
`6527`	`6528`	`return -1;`
`6528`	`6529`	`}`
`6529`	`6530`	`Py_DECREF(result);`
`6530`	`6531`	`}`
`6531`	`6532`	`Py_SET_SIZE(self->stack, mark);`
	`6533`	`+ Py_DECREF(add_func);`
`6532`	`6534`	`}`
`6533`	`6535`
`6534`	`6536`	`return 0;`