gh-106168: Check allocated instead of size index bounds in PyList_SET_ITEM() (#111480)

scoder · web-flow · commit 940ee962a8a1 · 2023-10-30T12:24:21.000+01:00
Check the index bound assertions in PyList_SET_ITEM() against [0:allocated] instead of [0:size] to re-allow valid use cases that assign within the allocated area.
diff --git a/Include/cpython/listobject.h b/Include/cpython/listobject.h
@@ -39,7 +39,7 @@ static inline void
 PyList_SET_ITEM(PyObject *op, Py_ssize_t index, PyObject *value) {
     PyListObject *list = _PyList_CAST(op);
     assert(0 <= index);
-    assert(index < Py_SIZE(list));
+    assert(index < list->allocated);
     list->ob_item[index] = value;
 }
 #define PyList_SET_ITEM(op, index, value) \

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ static inline void`
`39`	`39`	`PyList_SET_ITEM(PyObject op, Py_ssize_t index, PyObject value) {`
`40`	`40`	`PyListObject *list = _PyList_CAST(op);`
`41`	`41`	`assert(0 <= index);`
`42`		`- assert(index < Py_SIZE(list));`
	`42`	`+ assert(index < list->allocated);`
`43`	`43`	`list->ob_item[index] = value;`
`44`	`44`	`}`
`45`	`45`	`#define PyList_SET_ITEM(op, index, value) \`