Issue #3369: fix memory leak in floatobject.c. Thanks Kristján Jónsson

mdickinson · mdickinson · commit 943f33912c24 · 2008-07-21T22:49:36.000Z
for the report and fix.
diff --git a/Objects/floatobject.c b/Objects/floatobject.c
@@ -223,13 +223,19 @@ PyFloat_FromString(PyObject *v)
 			p++;
 		}
 		if (PyOS_strnicmp(p, "inf", 4) == 0) {
+			if (s_buffer != NULL)
+				PyMem_FREE(s_buffer);
 			Py_RETURN_INF(sign);
 		}
 		if (PyOS_strnicmp(p, "infinity", 9) == 0) {
+			if (s_buffer != NULL)
+				PyMem_FREE(s_buffer);
 			Py_RETURN_INF(sign);
 		}
 #ifdef Py_NAN
 		if(PyOS_strnicmp(p, "nan", 4) == 0) {
+			if (s_buffer != NULL)
+				PyMem_FREE(s_buffer);
 			Py_RETURN_NAN;
 		}
 #endif

Original file line number	Diff line number	Diff line change
`@@ -223,13 +223,19 @@ PyFloat_FromString(PyObject *v)`
`223`	`223`	`p++;`
`224`	`224`	`}`
`225`	`225`	`if (PyOS_strnicmp(p, "inf", 4) == 0) {`
	`226`	`+ if (s_buffer != NULL)`
	`227`	`+ PyMem_FREE(s_buffer);`
`226`	`228`	`Py_RETURN_INF(sign);`
`227`	`229`	`}`
`228`	`230`	`if (PyOS_strnicmp(p, "infinity", 9) == 0) {`
	`231`	`+ if (s_buffer != NULL)`
	`232`	`+ PyMem_FREE(s_buffer);`
`229`	`233`	`Py_RETURN_INF(sign);`
`230`	`234`	`}`
`231`	`235`	`#ifdef Py_NAN`
`232`	`236`	`if(PyOS_strnicmp(p, "nan", 4) == 0) {`
	`237`	`+ if (s_buffer != NULL)`
	`238`	`+ PyMem_FREE(s_buffer);`
`233`	`239`	`Py_RETURN_NAN;`
`234`	`240`	`}`
`235`	`241`	`#endif`