Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 953e4e5

Browse files
committed
Whoops, I missed a few more places that were using slicing from the operator module
1 parent 425136b commit 953e4e5

3 files changed

Lines changed: 2 additions & 39 deletions

File tree

Lib/ctypes/test/test_arrays.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,8 @@ def test_simple(self):
5757

5858
self.failUnlessEqual(len(ca), 3)
5959

60-
# slicing is now supported, but not extended slicing (3-argument)!
61-
from operator import getslice, delitem
62-
self.assertRaises(TypeError, getslice, ca, 0, 1, -1)
63-
6460
# cannot delete items
61+
from operator import delitem
6562
self.assertRaises(TypeError, delitem, ca, 0)
6663

6764
def test_numeric_arrays(self):

Lib/ctypes/test/test_slicing.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,17 @@ def test_setslice_cint(self):
4545
b[33::-3] = range(12)
4646
self.failUnlessEqual(a[:], b)
4747

48-
from operator import setslice, setitem
48+
from operator import setitem
4949

5050
# TypeError: int expected instead of str instance
51-
self.assertRaises(TypeError, setslice, a, 0, 5, "abcde")
5251
self.assertRaises(TypeError, setitem, a, slice(0, 5), "abcde")
5352
# TypeError: int expected instead of str instance
54-
self.assertRaises(TypeError, setslice, a, 0, 5, ["a", "b", "c", "d", "e"])
5553
self.assertRaises(TypeError, setitem, a, slice(0, 5),
5654
["a", "b", "c", "d", "e"])
5755
# TypeError: int expected instead of float instance
58-
self.assertRaises(TypeError, setslice, a, 0, 5, [1, 2, 3, 4, 3.14])
5956
self.assertRaises(TypeError, setitem, a, slice(0, 5),
6057
[1, 2, 3, 4, 3.14])
6158
# ValueError: Can only assign sequence of same size
62-
self.assertRaises(ValueError, setslice, a, 0, 5, range(32))
6359
self.assertRaises(ValueError, setitem, a, slice(0, 5), range(32))
6460

6561
def test_char_ptr(self):
@@ -86,8 +82,6 @@ def test_char_ptr(self):
8682
self.assertRaises(ValueError, operator.getitem,
8783
res, slice(-5, None, None))
8884

89-
self.assertRaises(TypeError, operator.setslice,
90-
res, 0, 5, "abcde")
9185
self.assertRaises(TypeError, operator.setitem,
9286
res, slice(0, 5), "abcde")
9387
dll.my_free(res)
@@ -150,8 +144,6 @@ def test_wchar_ptr(self):
150144
self.failUnlessEqual(res[len(s)-1:5:-7], s[:5:-7])
151145

152146
import operator
153-
self.assertRaises(TypeError, operator.setslice,
154-
res, 0, 5, "abcde")
155147
self.assertRaises(TypeError, operator.setitem,
156148
res, slice(0, 5), "abcde")
157149
dll.my_free(res)

Lib/test/test_operator.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,6 @@ def test_delitem(self):
137137
self.failUnless(operator.delitem(a, 1) is None)
138138
self.assert_(a == [4, 2, 1])
139139

140-
def test_delslice(self):
141-
a = list(range(10))
142-
self.failUnlessRaises(TypeError, operator.delslice, a)
143-
self.failUnlessRaises(TypeError, operator.delslice, a, None, None)
144-
self.failUnless(operator.delslice(a, 2, 8) is None)
145-
self.assert_(a == [0, 1, 8, 9])
146-
operator.delslice(a, 0, test_support.MAX_Py_ssize_t)
147-
self.assertEqual(a, [])
148-
149140
def test_floordiv(self):
150141
self.failUnlessRaises(TypeError, operator.floordiv, 5)
151142
self.failUnlessRaises(TypeError, operator.floordiv, None, None)
@@ -162,14 +153,6 @@ def test_getitem(self):
162153
self.failUnlessRaises(TypeError, operator.getitem, a, None)
163154
self.failUnless(operator.getitem(a, 2) == 2)
164155

165-
def test_getslice(self):
166-
a = list(range(10))
167-
self.failUnlessRaises(TypeError, operator.getslice)
168-
self.failUnlessRaises(TypeError, operator.getslice, a, None, None)
169-
self.failUnless(operator.getslice(a, 4, 6) == [4, 5])
170-
b = operator.getslice(a, 0, test_support.MAX_Py_ssize_t)
171-
self.assertEqual(b, a)
172-
173156
def test_indexOf(self):
174157
self.failUnlessRaises(TypeError, operator.indexOf)
175158
self.failUnlessRaises(TypeError, operator.indexOf, None, None)
@@ -298,15 +281,6 @@ def test_setitem(self):
298281
self.assert_(a == [2, 1, 2])
299282
self.assertRaises(IndexError, operator.setitem, a, 4, 2)
300283

301-
def test_setslice(self):
302-
a = list(range(4))
303-
self.failUnlessRaises(TypeError, operator.setslice, a)
304-
self.failUnlessRaises(TypeError, operator.setslice, a, None, None, None)
305-
self.failUnless(operator.setslice(a, 1, 3, [2, 1]) is None)
306-
self.assert_(a == [0, 2, 1, 3])
307-
operator.setslice(a, 0, test_support.MAX_Py_ssize_t, [])
308-
self.assertEqual(a, [])
309-
310284
def test_sub(self):
311285
self.failUnlessRaises(TypeError, operator.sub)
312286
self.failUnlessRaises(TypeError, operator.sub, None, None)

0 commit comments

Comments
 (0)