bpo-38155: Add __all__ to datetime module (GH-16203)

ta1hia · pganssle · commit 96b1c59c7153 · 2019-09-19T14:34:41.000+01:00
https://bugs.python.org/issue38155
diff --git a/Lib/datetime.py b/Lib/datetime.py
@@ -4,6 +4,10 @@
 time zone and DST data sources.
 """
 
+__all__ = ("date", "datetime", "time", "timedelta", "timezone", "tzinfo",
+           "MINYEAR", "MAXYEAR")
+
+
 import time as _time
 import math as _math
 import sys
diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py
@@ -62,6 +62,12 @@ def test_constants(self):
         self.assertEqual(datetime.MINYEAR, 1)
         self.assertEqual(datetime.MAXYEAR, 9999)
 
+    def test_all(self):
+        """Test that __all__ only points to valid attributes."""
+        all_attrs = dir(datetime_module)
+        for attr in datetime_module.__all__:
+            self.assertIn(attr, all_attrs)
+
     def test_name_cleanup(self):
         if '_Pure' in self.__class__.__name__:
             self.skipTest('Only run for Fast C implementation')
diff --git a/Misc/NEWS.d/next/Library/2019-09-16-21-47-48.bpo-38155.d92lRc.rst b/Misc/NEWS.d/next/Library/2019-09-16-21-47-48.bpo-38155.d92lRc.rst
@@ -0,0 +1 @@
+Add ``__all__`` to  :mod:`datetime`. Patch by Tahia Khan.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Add ``__all__`` to :mod:`datetime`. Patch by Tahia Khan.