bpo-26502: Implement FrameSummary.__len__() (GH-8632)

berkerpeksag · encukou · commit 9797b7ae4496 · 2018-09-10T10:02:33.000-07:00
diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
@@ -868,6 +868,7 @@ def extract():
             (__file__, lineno+2, 'test_extract_stack', 'result = extract()'),
             (__file__, lineno+1, 'extract', 'return traceback.extract_stack()'),
             ])
+        self.assertEqual(len(result[0]), 4)
 
 
 class TestFrame(unittest.TestCase):
@@ -900,6 +901,10 @@ def test_explicit_line(self):
         f = traceback.FrameSummary("f", 1, "dummy", line="line")
         self.assertEqual("line", f.line)
 
+    def test_len(self):
+        f = traceback.FrameSummary("f", 1, "dummy", line="line")
+        self.assertEqual(len(f), 4)
+
 
 class TestStack(unittest.TestCase):
 
diff --git a/Lib/traceback.py b/Lib/traceback.py
@@ -279,6 +279,9 @@ def __repr__(self):
         return "<FrameSummary file {filename}, line {lineno} in {name}>".format(
             filename=self.filename, lineno=self.lineno, name=self.name)
 
+    def __len__(self):
+        return 4
+
     @property
     def line(self):
         if self._line is None:
diff --git a/Misc/NEWS.d/next/Library/2018-08-02-20-39-32.bpo-26502.eGXr_k.rst b/Misc/NEWS.d/next/Library/2018-08-02-20-39-32.bpo-26502.eGXr_k.rst
@@ -0,0 +1,2 @@
+Implement ``traceback.FrameSummary.__len__()`` method to preserve
+compatibility with the old tuple API.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Implement ``traceback.FrameSummary.__len__()`` method to preserve
	`2`	`+compatibility with the old tuple API.`