Free parse tree when deleting parser.

gvanrossum · gvanrossum · commit 99f02d43f3d8 · 1990-11-18T17:38:42.000Z
diff --git a/Parser/parser.c b/Parser/parser.c
@@ -96,8 +96,6 @@ newparser(g, start)
 	ps->p_grammar = g;
 	ps->p_tree = newnode(start);
 	if (ps->p_tree == NULL) {
-		if (ps->p_tree != NULL)
-			DEL(ps->p_tree); /* XXX freeing a node!?! */
 		DEL(ps);
 		return NULL;
 	}
@@ -110,6 +108,9 @@ void
 delparser(ps)
 	parser_state *ps;
 {
+	/* NB If you want to save the parse tree,
+	   you must set p_tree to NULL before calling delparser! */
+	freenode(ps->p_tree);
 	DEL(ps);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,6 @@ newparser(g, start)`
`96`	`96`	`ps->p_grammar = g;`
`97`	`97`	`ps->p_tree = newnode(start);`
`98`	`98`	`if (ps->p_tree == NULL) {`
`99`		`- if (ps->p_tree != NULL)`
`100`		`- DEL(ps->p_tree); /* XXX freeing a node!?! */`
`101`	`99`	`DEL(ps);`
`102`	`100`	`return NULL;`
`103`	`101`	`}`
`@@ -110,6 +108,9 @@ void`
`110`	`108`	`delparser(ps)`
`111`	`109`	`parser_state *ps;`
`112`	`110`	`{`
	`111`	`+ /* NB If you want to save the parse tree,`
	`112`	`+ you must set p_tree to NULL before calling delparser! */`
	`113`	`+ freenode(ps->p_tree);`
`113`	`114`	`DEL(ps);`
`114`	`115`	`}`
`115`	`116`