Issue #11746: Fix SSLContext.load_cert_chain() to accept elliptic curve private keys.

pitrou · pitrou · commit 9c25486093a2 · 2011-04-03T18:15:34.000+02:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -49,6 +49,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #11746: Fix SSLContext.load_cert_chain() to accept elliptic curve
+  private keys.
+
 - sys.getfilesystemencoding() raises a RuntimeError if initfsencoding() was not
   called yet: detect bootstrap (startup) issues earlier.
 
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
@@ -1623,7 +1623,7 @@ load_cert_chain(PySSLContext *self, PyObject *args, PyObject *kwds)
         goto error;
     }
     PySSL_BEGIN_ALLOW_THREADS
-    r = SSL_CTX_use_RSAPrivateKey_file(self->ctx,
+    r = SSL_CTX_use_PrivateKey_file(self->ctx,
         PyBytes_AS_STRING(keyfile ? keyfile_bytes : certfile_bytes),
         SSL_FILETYPE_PEM);
     PySSL_END_ALLOW_THREADS

Original file line number	Diff line number	Diff line change
`@@ -1623,7 +1623,7 @@ load_cert_chain(PySSLContext self, PyObject args, PyObject *kwds)`
`1623`	`1623`	`goto error;`
`1624`	`1624`	`}`
`1625`	`1625`	`PySSL_BEGIN_ALLOW_THREADS`
`1626`		`- r = SSL_CTX_use_RSAPrivateKey_file(self->ctx,`
	`1626`	`+ r = SSL_CTX_use_PrivateKey_file(self->ctx,`
`1627`	`1627`	`PyBytes_AS_STRING(keyfile ? keyfile_bytes : certfile_bytes),`
`1628`	`1628`	`SSL_FILETYPE_PEM);`
`1629`	`1629`	`PySSL_END_ALLOW_THREADS`