add InvalidURL exception - raised if port is given but empty or non-numeric

Skip Montanaro · Skip Montanaro · commit 9d38997e8c4d · 2002-03-24T16:53:50.000Z
diff --git a/Lib/httplib.py b/Lib/httplib.py
@@ -347,7 +347,10 @@ def _set_hostport(self, host, port):
         if port is None:
             i = host.find(':')
             if i >= 0:
-                port = int(host[i+1:])
+                try:
+                    port = int(host[i+1:])
+                except ValueError:
+                    raise InvalidURL, "nonnumeric port: '%s'"%host[i+1:]
                 host = host[:i]
             else:
                 port = self.default_port
@@ -808,6 +811,9 @@ class HTTPException(Exception):
 class NotConnected(HTTPException):
     pass
 
+class InvalidURL(HTTPException):
+    pass
+
 class UnknownProtocol(HTTPException):
     def __init__(self, version):
         self.version = version
