Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit a226b57

Browse files
committed
Pass DIRMODE and FILEMODE to Mac/OSX/Makefile on framework builds (and
honor them). Use this when building the MacOSX binary installer to get group-writeable files. Ths fix works for directories and executables, not for files just yet, because of bug #735274.
1 parent 8b6ed26 commit a226b57

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

Mac/OSX/Dist/build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ fi
7070

7171
$PYTHONSRC/configure --enable-framework=$INSTALLROOT/Library/Frameworks LDFLAGS=-Wl,-x
7272
make
73-
make frameworkinstall
73+
make DIRMODE=775 EXEMODE=775 FILEMODE=664 frameworkinstall
7474

7575
if [ "$builddocs" = "y" -o "$builddocs" = "Y" ]; then
7676
./python.exe $PYTHONSRC/Mac/OSX/setupDocs.py build

Mac/OSX/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ INSTALLED_PYTHONW=$(APPINSTALLDIR)/Contents/MacOS/python
2222

2323
# Items more-or-less copied from the main Makefile
2424
DIRMODE=755
25+
FILEMODE=644
2526
INSTALL=/usr/bin/install -c
2627
INSTALL_SYMLINK=ln -fs
2728
INSTALL_PROGRAM=${INSTALL}
2829
INSTALL_SCRIPT= ${INSTALL_PROGRAM}
29-
INSTALL_DATA= ${INSTALL} -m 644
30+
INSTALL_DATA= ${INSTALL} -m ${FILEMODE}
3031
LN=ln
3132
STRIPFLAG=-s
3233
##OPT=-g -O3 -Wall -Wstrict-prototypes -Wno-long-double -no-cpp-precomp \

Makefile.pre.in

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -853,18 +853,19 @@ frameworkinstallstructure: $(LDLIBRARY)
853853
# This installs Mac/Lib into the framework
854854
frameworkinstallmaclib:
855855
$(MAKE) -f $(srcdir)/Mac/OSX/Makefile installmacsubtree \
856-
BUILDPYTHON=./$(BUILDPYTHON) \
856+
BUILDPYTHON=./$(BUILDPYTHON) DIRMODE=$(DIRMODE) FILEMODE=$(FILEMODE) \
857857
srcdir=$(srcdir) builddir=. prefix=$(prefix) LIBDEST=$(LIBDEST)
858858

859859
# This installs the IDE, the Launcher and other apps into /Applications
860860
frameworkinstallapps:
861861
$(MAKE) -f $(srcdir)/Mac/OSX/Makefile installapps \
862-
BUILDPYTHON=./$(BUILDPYTHON) \
862+
BUILDPYTHON=./$(BUILDPYTHON) DIRMODE=$(DIRMODE) FILEMODE=$(FILEMODE) \
863863
srcdir=$(srcdir) builddir=. dstroot=$(PYTHONFRAMEWORKPREFIX)/../..
864864

865865
# This install the unix python and pythonw tools in /usr/local/bin
866866
frameworkinstallunixtools:
867867
$(MAKE) -f $(srcdir)/Mac/OSX/Makefile installunixtools \
868+
DIRMODE=$(DIRMODE) FILEMODE=$(FILEMODE) \
868869
srcdir=$(srcdir) builddir=. dstroot=$(PYTHONFRAMEWORKPREFIX)/../..
869870

870871
# This installs IDLE

0 commit comments

Comments
 (0)