Changed builtin_sum to use PyNumber_InPlaceAdd (same semantics, but fixes

aleaxit · aleaxit · commit a2777d3a55ca · 2003-10-25T12:49:56.000Z
a performance bug in sum(manylists)), same as in 2.3 maintenance branch.
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -1840,7 +1840,7 @@ builtin_sum(PyObject *self, PyObject *args)
 			}
 			break;
 		}
-		temp = PyNumber_Add(result, item);
+		temp = PyNumber_InPlaceAdd(result, item);
 		Py_DECREF(result);
 		Py_DECREF(item);
 		result = temp;

Original file line number	Diff line number	Diff line change
`@@ -1840,7 +1840,7 @@ builtin_sum(PyObject self, PyObject args)`
`1840`	`1840`	`}`
`1841`	`1841`	`break;`
`1842`	`1842`	`}`
`1843`		`- temp = PyNumber_Add(result, item);`
	`1843`	`+ temp = PyNumber_InPlaceAdd(result, item);`
`1844`	`1844`	`Py_DECREF(result);`
`1845`	`1845`	`Py_DECREF(item);`
`1846`	`1846`	`result = temp;`