GH-139193: Fix dump_stack when PYTHON_LLTRACE=4 (GH-139384)

sergey-miryanov · web-flow · commit a4709e525f5b · 2025-10-22T14:14:25.000+01:00
diff --git a/Include/internal/pycore_stackref.h b/Include/internal/pycore_stackref.h
@@ -296,6 +296,12 @@ PyStackRef_IsError(_PyStackRef ref)
     return ref.bits == Py_TAG_INVALID;
 }
 
+static inline bool
+PyStackRef_IsMalformed(_PyStackRef ref)
+{
+    return (ref.bits & Py_TAG_BITS) == Py_TAG_INVALID;
+}
+
 static inline bool
 PyStackRef_IsValid(_PyStackRef ref)
 {
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -160,6 +160,10 @@ dump_item(_PyStackRef item)
         printf("<NULL>");
         return;
     }
+    if (PyStackRef_IsMalformed(item)) {
+        printf("<INVALID>");
+        return;
+    }
     if (PyStackRef_IsTaggedInt(item)) {
         printf("%" PRId64, (int64_t)PyStackRef_UntagInt(item));
         return;

Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,12 @@ PyStackRef_IsError(_PyStackRef ref)`
`296`	`296`	`return ref.bits == Py_TAG_INVALID;`
`297`	`297`	`}`
`298`	`298`
	`299`	`+static inline bool`
	`300`	`+PyStackRef_IsMalformed(_PyStackRef ref)`
	`301`	`+{`
	`302`	`+ return (ref.bits & Py_TAG_BITS) == Py_TAG_INVALID;`
	`303`	`+}`
	`304`	`+`
`299`	`305`	`static inline bool`
`300`	`306`	`PyStackRef_IsValid(_PyStackRef ref)`
`301`	`307`	`{`