- Issue #13021: Missing decref on an error path. Thanks to Suman Saha for

warsaw · warsaw · commit a80b14cc5f83 · 2011-09-20T14:58:01.000-04:00
finding the bug and providing a patch.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.3 Alpha 1?
 Core and Builtins
 -----------------
 
+- Issue #13021: Missing decref on an error path.  Thanks to Suman Saha for
+  finding the bug and providing a patch.
+
 - Issue #12973: Fix overflow check that relied on undefined behaviour in
   list_repeat.  This bug caused test_list to fail with recent versions
   of Clang.
diff --git a/Python/pythonrun.c b/Python/pythonrun.c
@@ -1251,8 +1251,10 @@ PyRun_SimpleFileExFlags(FILE *fp, const char *filename, int closeit,
             Py_DECREF(f);
             return -1;
         }
-        if (PyDict_SetItemString(d, "__cached__", Py_None) < 0)
+        if (PyDict_SetItemString(d, "__cached__", Py_None) < 0) {
+            Py_DECREF(f);
             return -1;
+        }
         set_file_name = 1;
         Py_DECREF(f);
     }

Original file line number	Diff line number	Diff line change
`@@ -1251,8 +1251,10 @@ PyRun_SimpleFileExFlags(FILE fp, const char filename, int closeit,`
`1251`	`1251`	`Py_DECREF(f);`
`1252`	`1252`	`return -1;`
`1253`	`1253`	`}`
`1254`		`- if (PyDict_SetItemString(d, "__cached__", Py_None) < 0)`
	`1254`	`+ if (PyDict_SetItemString(d, "__cached__", Py_None) < 0) {`
	`1255`	`+ Py_DECREF(f);`
`1255`	`1256`	`return -1;`
	`1257`	`+ }`
`1256`	`1258`	`set_file_name = 1;`
`1257`	`1259`	`Py_DECREF(f);`
`1258`	`1260`	`}`