Fix reference leak in tb_printinternal()

vstinner · vstinner · commit a88b2f4e5e8e · 2016-08-20T03:05:13.000+02:00
Issue #26823.
diff --git a/Python/traceback.c b/Python/traceback.c
@@ -435,6 +435,7 @@ tb_printinternal(PyTracebackObject *tb, PyObject *f, long limit)
                         line = PyUnicode_FromFormat(
                         "  [Previous line repeated %d more times]\n", cnt-3);
                         err = PyFile_WriteObject(line, f, Py_PRINT_RAW);
+                        Py_DECREF(line);
                     }
                     last_file = tb->tb_frame->f_code->co_filename;
                     last_line = tb->tb_lineno;
@@ -456,6 +457,7 @@ tb_printinternal(PyTracebackObject *tb, PyObject *f, long limit)
         line = PyUnicode_FromFormat(
         "  [Previous line repeated %d more times]\n", cnt-3);
         err = PyFile_WriteObject(line, f, Py_PRINT_RAW);
+        Py_DECREF(line);
     }
     return err;
 }

Original file line number	Diff line number	Diff line change
`@@ -435,6 +435,7 @@ tb_printinternal(PyTracebackObject tb, PyObject f, long limit)`
`435`	`435`	`line = PyUnicode_FromFormat(`
`436`	`436`	`" [Previous line repeated %d more times]\n", cnt-3);`
`437`	`437`	`err = PyFile_WriteObject(line, f, Py_PRINT_RAW);`
	`438`	`+ Py_DECREF(line);`
`438`	`439`	`}`
`439`	`440`	`last_file = tb->tb_frame->f_code->co_filename;`
`440`	`441`	`last_line = tb->tb_lineno;`
`@@ -456,6 +457,7 @@ tb_printinternal(PyTracebackObject tb, PyObject f, long limit)`
`456`	`457`	`line = PyUnicode_FromFormat(`
`457`	`458`	`" [Previous line repeated %d more times]\n", cnt-3);`
`458`	`459`	`err = PyFile_WriteObject(line, f, Py_PRINT_RAW);`
	`460`	`+ Py_DECREF(line);`
`459`	`461`	`}`
`460`	`462`	`return err;`
`461`	`463`	`}`