Don't use dir() to find instance attribute names.

nascheme · nascheme · commit a8aefe535c87 · 2001-09-03T15:47:21.000Z
diff --git a/Lib/distutils/dist.py b/Lib/distutils/dist.py
@@ -122,9 +122,7 @@ def __init__ (self, attrs=None):
         # worth it.  Also delegate 'get_XXX()' methods to the 'metadata'
         # object in a sneaky and underhanded (but efficient!) way.
         self.metadata = DistributionMetadata()
-        method_basenames = dir(self.metadata) + \
-                           ['fullname', 'contact', 'contact_email']
-        for basename in method_basenames:
+        for basename in self.metadata._METHOD_BASENAMES:
             method_name = "get_" + basename
             setattr(self, method_name, getattr(self.metadata, method_name))
 
@@ -962,6 +960,12 @@ class DistributionMetadata:
     author, and so forth.
     """
 
+    _METHOD_BASENAMES = ("name", "version", "author", "author_email",
+                         "maintainer", "maintainer_email", "url",
+                         "license", "description", "long_description",
+                         "keywords", "platforms", "fullname", "contact",
+                         "contact_email", "licence")
+
     def __init__ (self):
         self.name = None
         self.version = None
