Issue #19437: Fix _io._IOBase.close(), handle _PyObject_SetAttrId() failure

vstinner · vstinner · commit aa5bbfaa77a1 · 2013-11-08T00:29:41.000+01:00
diff --git a/Modules/_io/iobase.c b/Modules/_io/iobase.c
@@ -186,11 +186,16 @@ iobase_close(PyObject *self, PyObject *args)
         Py_RETURN_NONE;
 
     res = PyObject_CallMethodObjArgs(self, _PyIO_str_flush, NULL);
-    _PyObject_SetAttrId(self, &PyId___IOBase_closed, Py_True);
-    if (res == NULL) {
+
+    if (_PyObject_SetAttrId(self, &PyId___IOBase_closed, Py_True) < 0) {
+        Py_XDECREF(res);
         return NULL;
     }
-    Py_XDECREF(res);
+
+    if (res == NULL)
+        return NULL;
+
+    Py_DECREF(res);
     Py_RETURN_NONE;
 }
 
