Merged revisions 79281 via svnmerge from

Victor Stinner · Victor Stinner · commit abdb21a3a89e · 2010-03-22T12:53:14.000Z
svn+ssh://pythondev@svn.python.org/python/branches/py3k

................
  r79281 | victor.stinner | 2010-03-22 13:50:40 +0100 (lun., 22 mars 2010) | 16 lines

  Merged revisions 79278,79280 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r79278 | victor.stinner | 2010-03-22 13:24:37 +0100 (lun., 22 mars 2010) | 2 lines

    Issue #1583863: An unicode subclass can now override the __str__ method
  ........
    r79280 | victor.stinner | 2010-03-22 13:36:28 +0100 (lun., 22 mars 2010) | 5 lines

    Fix the NEWS about my last commit: an unicode subclass can now override the
    __unicode__ method (and not the __str__ method).

    Simplify also the testcase.
  ........
................
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
@@ -1223,6 +1223,14 @@ def test_raiseMemError(self):
         self.assertRaises(MemoryError, alloc)
         self.assertRaises(MemoryError, alloc)
 
+    def test_format_subclass(self):
+        class S(str):
+            def __str__(self):
+                return '__str__ overridden'
+        s = S('xxx')
+        self.assertEquals("%s" % s, '__str__ overridden')
+        self.assertEquals("{}".format(s), '__str__ overridden')
+
 
 def test_main():
     support.run_unittest(__name__)
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -9,6 +9,11 @@ What's New in Python 3.1.3?
 
 *Release date: 20XX-XX-XX*
 
+Core and Builtins
+-----------------
+
+- Issue #1583863: An str subclass can now override the __str__ method
+
 Library
 -------
 
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -9308,7 +9308,7 @@ PyObject *PyUnicode_Format(PyObject *format,
             case 's':
             case 'r':
             case 'a':
-                if (PyUnicode_Check(v) && c == 's') {
+                if (PyUnicode_CheckExact(v) && c == 's') {
                     temp = v;
                     Py_INCREF(temp);
                 }

Original file line number	Diff line number	Diff line change
`@@ -9308,7 +9308,7 @@ PyObject PyUnicode_Format(PyObject format,`
`9308`	`9308`	`case 's':`
`9309`	`9309`	`case 'r':`
`9310`	`9310`	`case 'a':`
`9311`		`- if (PyUnicode_Check(v) && c == 's') {`
	`9311`	`+ if (PyUnicode_CheckExact(v) && c == 's') {`
`9312`	`9312`	`temp = v;`
`9313`	`9313`	`Py_INCREF(temp);`
`9314`	`9314`	`}`