Revert a wrong commit.

Thomas Heller · Thomas Heller · commit ace8ba8d4b27 · 2007-07-11T20:01:43.000Z
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -44,7 +44,6 @@ static int
 type_set_name(PyTypeObject *type, PyObject *value, void *context)
 {
 	PyHeapTypeObject* et;
-	char *name;
 
 	if (!(type->tp_flags & Py_TPFLAGS_HEAPTYPE)) {
 		PyErr_Format(PyExc_TypeError,
@@ -56,25 +55,19 @@ type_set_name(PyTypeObject *type, PyObject *value, void *context)
 			     "can't delete %s.__name__", type->tp_name);
 		return -1;
 	}
-	if (PyString_Check(value)) {
-		value = PyUnicode_FromStringAndSize(PyString_AS_STRING(value),
-						    PyString_GET_SIZE(value));
+	if (PyUnicode_Check(value)) {
+		value = _PyUnicode_AsDefaultEncodedString(value, NULL);
 		if (value == NULL)
 			return -1;
-		/* XXX Isn't here a refcount leak? */
 	}
-	if (!PyUnicode_Check(value)) {
+	if (!PyString_Check(value)) {
 		PyErr_Format(PyExc_TypeError,
 			     "can only assign string to %s.__name__, not '%s'",
 			     type->tp_name, value->ob_type->tp_name);
 		return -1;
 	}
-
-	name = PyUnicode_AsString(value);
-	if (name == NULL)
-		return -1;
-
-	if (strlen(name) != PyUnicode_GET_SIZE(value)) {
+	if (strlen(PyString_AS_STRING(value))
+	    != (size_t)PyString_GET_SIZE(value)) {
 		PyErr_Format(PyExc_ValueError,
 			     "__name__ must not contain null bytes");
 		return -1;
@@ -87,7 +80,7 @@ type_set_name(PyTypeObject *type, PyObject *value, void *context)
 	Py_DECREF(et->ht_name);
 	et->ht_name = value;
 
-	type->tp_name = name;
+	type->tp_name = PyString_AS_STRING(value);
 
 	return 0;
 }
@@ -1665,7 +1658,7 @@ type_new(PyTypeObject *metatype, PyObject *args, PyObject *kwds)
 	}
 
 	/* Check arguments: (name, bases, dict) */
-	if (!PyArg_ParseTupleAndKeywords(args, kwds, "UO!O!:type", kwlist,
+	if (!PyArg_ParseTupleAndKeywords(args, kwds, "SO!O!:type", kwlist,
 					 &name,
 					 &PyTuple_Type, &bases,
 					 &PyDict_Type, &dict))
diff --git a/Python/errors.c b/Python/errors.c
@@ -575,7 +575,7 @@ PyErr_NewException(char *name, PyObject *base, PyObject *dict)
 			goto failure;
 	}
 	/* Create a real new-style class. */
-	result = PyObject_CallFunction((PyObject *)&PyType_Type, "UOO",
+	result = PyObject_CallFunction((PyObject *)&PyType_Type, "sOO",
 				       dot+1, bases, dict);
   failure:
 	Py_XDECREF(bases);

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ PyErr_NewException(char name, PyObject base, PyObject *dict)`
`575`	`575`	`goto failure;`
`576`	`576`	`}`
`577`	`577`	`/* Create a real new-style class. */`
`578`		`- result = PyObject_CallFunction((PyObject *)&PyType_Type, "UOO",`
	`578`	`+ result = PyObject_CallFunction((PyObject *)&PyType_Type, "sOO",`
`579`	`579`	`dot+1, bases, dict);`
`580`	`580`	`failure:`
`581`	`581`	`Py_XDECREF(bases);`