Fix a memory leak in reloading extension modules #3667

benjaminp · benjaminp · commit ad9565338c10 · 2008-09-04T02:28:15.000Z
Reviewer: Barry Warsaw
diff --git a/Python/import.c b/Python/import.c
@@ -612,7 +612,6 @@ _PyImport_FindExtension(char *name, char *filename)
 		mod = PyImport_AddModule(name);
 		if (mod == NULL)
 			return NULL;
-		Py_INCREF(mod);
 		mdict = PyModule_GetDict(mod);
 		if (mdict == NULL)
 			return NULL;
@@ -626,6 +625,7 @@ _PyImport_FindExtension(char *name, char *filename)
 		if (mod == NULL)
 			return NULL;
 		PyDict_SetItemString(PyImport_GetModuleDict(), name, mod);
+		Py_DECREF(mod);
 	}
 	if (_PyState_AddModule(mod, def) < 0) {
 		PyDict_DelItemString(PyImport_GetModuleDict(), name);
