There is no reason for imp.get_magic() to return a mutable bytearray

amauryfa · amauryfa · commit ae0b088f6ca4 · 2008-04-24T18:23:22.000Z
diff --git a/Python/import.c b/Python/import.c
@@ -2686,7 +2686,7 @@ imp_get_magic(PyObject *self, PyObject *noargs)
 	buf[2] = (char) ((pyc_magic >> 16) & 0xff);
 	buf[3] = (char) ((pyc_magic >> 24) & 0xff);
 
-	return PyBytes_FromStringAndSize(buf, 4);
+	return PyString_FromStringAndSize(buf, 4);
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -2686,7 +2686,7 @@ imp_get_magic(PyObject self, PyObject noargs)`
`2686`	`2686`	`buf[2] = (char) ((pyc_magic >> 16) & 0xff);`
`2687`	`2687`	`buf[3] = (char) ((pyc_magic >> 24) & 0xff);`
`2688`	`2688`
`2689`		`- return PyBytes_FromStringAndSize(buf, 4);`
	`2689`	`+ return PyString_FromStringAndSize(buf, 4);`
`2690`	`2690`	`}`
`2691`	`2691`
`2692`	`2692`	`static PyObject *`