(Merge 3.2) Issue #12175: FileIO.readall() now raises a ValueError instead of

Victor Stinner · Victor Stinner · commit af62c7d3deb6 · 2011-05-25T22:13:47.000+02:00
an IOError if the file is closed.
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
@@ -2512,6 +2512,8 @@ def test_io_after_close(self):
             self.assertRaises(ValueError, f.read)
             if hasattr(f, "read1"):
                 self.assertRaises(ValueError, f.read1, 1024)
+            if hasattr(f, "readall"):
+                self.assertRaises(ValueError, f.readall)
             if hasattr(f, "readinto"):
                 self.assertRaises(ValueError, f.readinto, bytearray(1024))
             self.assertRaises(ValueError, f.readline)
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -1062,6 +1062,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #12175: FileIO.readall() now raises a ValueError instead of an IOError
+  if the file is closed.
+
 - Issue #10916: mmap should not segfault when a file is mapped using 0 as length
   and a non-zero offset, and an attempt to read past the end of file is made
   (IndexError is raised instead).  Patch by Ross Lagerwall.
diff --git a/Modules/_io/fileio.c b/Modules/_io/fileio.c
@@ -583,6 +583,8 @@ fileio_readall(fileio *self)
     Py_ssize_t total = 0;
     int n;
 
+    if (self->fd < 0)
+        return err_closed();
     if (!_PyVerify_fd(self->fd))
         return PyErr_SetFromErrno(PyExc_IOError);
 
