readline() args must be an int #3521

benjaminp · benjaminp · commit b01138a66ec3 · 2009-04-24T22:59:52.000Z
diff --git a/Lib/_pyio.py b/Lib/_pyio.py
@@ -460,6 +460,8 @@ def nreadahead():
                 return 1
         if limit is None:
             limit = -1
+        elif not isinstance(limit, int):
+            raise TypeError("limit must be an integer")
         res = bytearray()
         while limit < 0 or len(res) < limit:
             b = self.read(nreadahead())
@@ -1741,6 +1743,8 @@ def readline(self, limit=None):
             raise ValueError("read from closed file")
         if limit is None:
             limit = -1
+        elif not isinstance(limit, int):
+            raise TypeError("limit must be an integer")
 
         # Grab all the decoded text (we will rewind any extra bits later).
         line = self._get_decoded_chars()
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
@@ -319,7 +319,7 @@ def test_buffered_file_io(self):
         f.close()
 
     def test_readline(self):
-        f = io.open(support.TESTFN, "wb")
+        f = self.open(support.TESTFN, "wb")
         f.write(b"abc\ndef\nxyzzy\nfoo\x00bar\nanother line")
         f.close()
         f = self.open(support.TESTFN, "rb")
@@ -329,7 +329,10 @@ def test_readline(self):
         self.assertEqual(f.readline(4), b"zzy\n")
         self.assertEqual(f.readline(), b"foo\x00bar\n")
         self.assertEqual(f.readline(), b"another line")
+        self.assertRaises(TypeError, f.readline, 5.3)
         f.close()
+        f = self.open(support.TESTFN, "r")
+        self.assertRaises(TypeError, f.readline, 5.3)
 
     def test_raw_bytes_io(self):
         f = self.BytesIO()
