Fix another leak in bsddb, and avoid use of uninitialized value -- funny how

Yhg1s · Yhg1s · commit b2820ae35546 · 2006-03-12T00:01:38.000Z
gcc 4.0.x wasn't complaining about *that* one ;)
diff --git a/Modules/_bsddb.c b/Modules/_bsddb.c
@@ -1742,6 +1742,7 @@ DB_join(DBObject* self, PyObject* args)
             return NULL;
         }
         cursors[x] = ((DBCursorObject*)item)->dbc;
+        Py_DECREF(item);
     }
 
     MYDB_BEGIN_ALLOW_THREADS;
@@ -2017,7 +2018,7 @@ _db_compareCallback(DB* db,
 {
     int res = 0;
     PyObject *args;
-    PyObject *result;
+    PyObject *result = NULL;
     DBObject *self = (DBObject *)db->app_private;
 
     if (self == NULL || self->btCompareCallback == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -1742,6 +1742,7 @@ DB_join(DBObject* self, PyObject* args)`
`1742`	`1742`	`return NULL;`
`1743`	`1743`	`}`
`1744`	`1744`	`cursors[x] = ((DBCursorObject*)item)->dbc;`
	`1745`	`+ Py_DECREF(item);`
`1745`	`1746`	`}`
`1746`	`1747`
`1747`	`1748`	`MYDB_BEGIN_ALLOW_THREADS;`
`@@ -2017,7 +2018,7 @@ _db_compareCallback(DB* db,`
`2017`	`2018`	`{`
`2018`	`2019`	`int res = 0;`
`2019`	`2020`	`PyObject *args;`
`2020`		`- PyObject *result;`
	`2021`	`+ PyObject *result = NULL;`
`2021`	`2022`	`DBObject self = (DBObject )db->app_private;`
`2022`	`2023`
`2023`	`2024`	`if (self == NULL \|\| self->btCompareCallback == NULL) {`