At least one of the buildbots was complaining about newview being used

nnorwitz · nnorwitz · commit b35f128711e3 · 2007-10-07T19:26:50.000Z
without being initialized.  Also make the code conform to the comment and
return the new object.  This code needs a test!
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
@@ -513,12 +513,11 @@ memory_subscript(PyMemoryViewObject *self, PyObject *key)
 		else {
 			/* Return a new memory-view object */
 			Py_buffer newview;
-			PyMemoryView_FromMemory(&newview);
+			memset(&newview, 0, sizeof(newview));
+			return PyMemoryView_FromMemory(&newview);
 		}
 	}
 
-
-
         Py_INCREF(Py_NotImplemented);
         return Py_NotImplemented;
 }

Original file line number	Diff line number	Diff line change
`@@ -513,12 +513,11 @@ memory_subscript(PyMemoryViewObject self, PyObject key)`
`513`	`513`	`else {`
`514`	`514`	`/* Return a new memory-view object */`
`515`	`515`	`Py_buffer newview;`
`516`		`- PyMemoryView_FromMemory(&newview);`
	`516`	`+ memset(&newview, 0, sizeof(newview));`
	`517`	`+ return PyMemoryView_FromMemory(&newview);`
`517`	`518`	`}`
`518`	`519`	`}`
`519`	`520`
`520`		`-`
`521`		`-`
`522`	`521`	`Py_INCREF(Py_NotImplemented);`
`523`	`522`	`return Py_NotImplemented;`
`524`	`523`	`}`