stringio doesn't have an encoding

benjaminp · benjaminp · commit b487e632826a · 2009-03-21T03:08:31.000Z
diff --git a/Lib/_pyio.py b/Lib/_pyio.py
@@ -1834,3 +1834,7 @@ def __repr__(self):
         # TextIOWrapper tells the encoding in its repr. In StringIO,
         # that's a implementation detail.
         return object.__repr__(self)
+
+    @property
+    def encoding(self):
+        return None
diff --git a/Lib/test/test_memoryio.py b/Lib/test/test_memoryio.py
@@ -451,7 +451,7 @@ def test_textio_properties(self):
 
         # These are just dummy values but we nevertheless check them for fear
         # of unexpected breakage.
-        self.assertEqual(memio.encoding, "utf-8")
+        self.assertTrue(memio.encoding is None)
         self.assertEqual(memio.errors, "strict")
         self.assertEqual(memio.line_buffering, False)
 
diff --git a/Modules/_stringio.c b/Modules/_stringio.c
@@ -665,7 +665,7 @@ stringio_encoding(StringIOObject *self, void *context)
 {
     CHECK_INITIALIZED(self);
     CHECK_CLOSED(self);
-    return PyUnicode_FromString("utf-8");
+    Py_RETURN_NONE;
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -665,7 +665,7 @@ stringio_encoding(StringIOObject self, void context)`
`665`	`665`	`{`
`666`	`666`	`CHECK_INITIALIZED(self);`
`667`	`667`	`CHECK_CLOSED(self);`
`668`		`- return PyUnicode_FromString("utf-8");`
	`668`	`+ Py_RETURN_NONE;`
`669`	`669`	`}`
`670`	`670`
`671`	`671`	`static PyObject *`