Issue #16168: Use specified socket type for domain sockets in SysLogHandler.

vsajip · vsajip · commit b5ca932be26a · 2012-10-09T08:19:25.000+01:00
diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
@@ -754,18 +754,12 @@ def __init__(self, address=('localhost', SYSLOG_UDP_PORT),
         self.formatter = None
 
     def _connect_unixsocket(self, address):
-        self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_DGRAM)
-        # syslog may require either DGRAM or STREAM sockets
+        self.socket = socket.socket(socket.AF_UNIX, self.socktype)
         try:
             self.socket.connect(address)
         except socket.error:
             self.socket.close()
-            self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
-            try:
-                self.socket.connect(address)
-            except socket.error:
-                self.socket.close()
-                raise
+            raise
 
     def encodePriority(self, facility, priority):
         """
