Fix wrapping into StopIteration of return values in generators and coroutines (#644)

1st1 · web-flow · commit b7c9150b6851 · 2017-03-12T15:53:07.000-04:00
diff --git a/Lib/test/test_coroutines.py b/Lib/test/test_coroutines.py
@@ -1103,6 +1103,21 @@ async def waiter(coro):
                                     "coroutine is being awaited already"):
             waiter(coro).send(None)
 
+    def test_await_16(self):
+        # See https://bugs.python.org/issue29600 for details.
+
+        async def f():
+            return ValueError()
+
+        async def g():
+            try:
+                raise KeyError
+            except:
+                return await f()
+
+        _, result = run_async(g())
+        self.assertIsNone(result.__context__)
+
     def test_with_1(self):
         class Manager:
             def __init__(self, name):
diff --git a/Objects/genobject.c b/Objects/genobject.c
@@ -574,8 +574,7 @@ _PyGen_SetStopIterationValue(PyObject *value)
     PyObject *e;
 
     if (value == NULL ||
-        (!PyTuple_Check(value) &&
-         !PyObject_TypeCheck(value, (PyTypeObject *) PyExc_StopIteration)))
+        (!PyTuple_Check(value) && !PyExceptionInstance_Check(value)))
     {
         /* Delay exception instantiation if we can */
         PyErr_SetObject(PyExc_StopIteration, value);

Original file line number	Diff line number	Diff line change
`@@ -574,8 +574,7 @@ _PyGen_SetStopIterationValue(PyObject *value)`
`574`	`574`	`PyObject *e;`
`575`	`575`
`576`	`576`	`if (value == NULL \|\|`
`577`		`- (!PyTuple_Check(value) &&`
`578`		`- !PyObject_TypeCheck(value, (PyTypeObject *) PyExc_StopIteration)))`
	`577`	`+ (!PyTuple_Check(value) && !PyExceptionInstance_Check(value)))`
`579`	`578`	`{`
`580`	`579`	`/* Delay exception instantiation if we can */`
`581`	`580`	`PyErr_SetObject(PyExc_StopIteration, value);`