I think there was a tiny bug in new_function() -- the 'defaults'

gvanrossum · gvanrossum · commit b88679b2a495 · 1998-05-22T00:57:31.000Z
argument was initialized to Py_None, but later checked for NULL.
Consistently use Py_None.
diff --git a/Modules/newmodule.c b/Modules/newmodule.c
@@ -109,7 +109,7 @@ new_function(unused, args)
 		Py_XDECREF(newfunc->func_name);
 		newfunc->func_name = name;
 	}
-	if (defaults != NULL) {
+	if (defaults != Py_None) {
 		Py_XINCREF(defaults);
 		Py_XDECREF(newfunc->func_defaults);
 		newfunc->func_defaults  = defaults;

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ new_function(unused, args)`
`109`	`109`	`Py_XDECREF(newfunc->func_name);`
`110`	`110`	`newfunc->func_name = name;`
`111`	`111`	`}`
`112`		`- if (defaults != NULL) {`
	`112`	`+ if (defaults != Py_None) {`
`113`	`113`	`Py_XINCREF(defaults);`
`114`	`114`	`Py_XDECREF(newfunc->func_defaults);`
`115`	`115`	`newfunc->func_defaults = defaults;`