Fix potential memory leak in parsetok.c (GH-11832)

pablogsal · web-flow · commit b9d2e9760184 · 2019-02-13T00:45:53.000Z
diff --git a/Parser/parsetok.c b/Parser/parsetok.c
@@ -370,7 +370,6 @@ parsetok(struct tok_state *tok, grammar *g, int start, perrdetail *err_ret,
                                 type_ignores.items[i], 0);
             }
         }
-        growable_int_array_deallocate(&type_ignores);
 
 #ifndef PGEN
         /* Check that the source for a single input statement really
@@ -405,6 +404,8 @@ parsetok(struct tok_state *tok, grammar *g, int start, perrdetail *err_ret,
     else
         n = NULL;
 
+    growable_int_array_deallocate(&type_ignores);
+
 #ifdef PY_PARSER_REQUIRES_FUTURE_KEYWORD
     *flags = ps->p_flags;
 #endif

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,6 @@ parsetok(struct tok_state tok, grammar g, int start, perrdetail *err_ret,`
`370`	`370`	`type_ignores.items[i], 0);`
`371`	`371`	`}`
`372`	`372`	`}`
`373`		`- growable_int_array_deallocate(&type_ignores);`
`374`	`373`
`375`	`374`	`#ifndef PGEN`
`376`	`375`	`/* Check that the source for a single input statement really`
`@@ -405,6 +404,8 @@ parsetok(struct tok_state tok, grammar g, int start, perrdetail *err_ret,`
`405`	`404`	`else`
`406`	`405`	`n = NULL;`
`407`	`406`
	`407`	`+ growable_int_array_deallocate(&type_ignores);`
	`408`	`+`
`408`	`409`	`#ifdef PY_PARSER_REQUIRES_FUTURE_KEYWORD`
`409`	`410`	`*flags = ps->p_flags;`
`410`	`411`	`#endif`