Issue 5449: Fix io.BytesIO to not accept arbitrary keywords

avassalotti · avassalotti · commit ba5c74329dad · 2009-08-04T23:19:13.000Z
Patch contributed by Erick Tryzelaar.
diff --git a/Lib/test/test_memoryio.py b/Lib/test/test_memoryio.py
@@ -461,6 +461,11 @@ def test_bytes_array(self):
         self.assertEqual(memio.write(a), 10)
         self.assertEqual(memio.getvalue(), buf)
 
+    def test_issue5449(self):
+        buf = self.buftype("1234567890")
+        self.ioclass(initial_bytes=buf)
+        self.assertRaises(TypeError, self.ioclass, buf, foo=None)
+
 
 class TextIOTestMixin:
 
diff --git a/Modules/_io/bytesio.c b/Modules/_io/bytesio.c
@@ -759,9 +759,11 @@ bytesio_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 static int
 bytesio_init(bytesio *self, PyObject *args, PyObject *kwds)
 {
+    char *kwlist[] = {"initial_bytes", NULL};
     PyObject *initvalue = NULL;
 
-    if (!PyArg_ParseTuple(args, "|O:BytesIO", &initvalue))
+    if (!PyArg_ParseTupleAndKeywords(args, kwds, "|O:BytesIO", kwlist,
+                                     &initvalue))
         return -1;
 
     /* In case, __init__ is called multiple times. */
