closes bpo-35991: Fix a potential double free in Modules/_randommodule.c. (GH-11849)

ZackerySpytz · benjaminp · commit bb3c05d7efca · 2019-02-13T23:43:17.000-08:00
diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-02-14-00-00-30.bpo-35991.xlbfSk.rst b/Misc/NEWS.d/next/Core and Builtins/2019-02-14-00-00-30.bpo-35991.xlbfSk.rst
@@ -0,0 +1 @@
+Fix a potential double free in Modules/_randommodule.c.
diff --git a/Modules/_randommodule.c b/Modules/_randommodule.c
@@ -292,7 +292,6 @@ random_seed(RandomObject *self, PyObject *args)
                               PY_LITTLE_ENDIAN,
                               0); /* unsigned */
     if (res == -1) {
-        PyMem_Free(key);
         goto Done;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix a potential double free in Modules/_randommodule.c.`
Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,6 @@ random_seed(RandomObject self, PyObject args)`
`292`	`292`	`PY_LITTLE_ENDIAN,`
`293`	`293`	`0); /* unsigned */`
`294`	`294`	`if (res == -1) {`
`295`		`- PyMem_Free(key);`
`296`	`295`	`goto Done;`
`297`	`296`	`}`
`298`	`297`