Fix a minor bug in optimizer symbols

markshannon · markshannon · commit bb7efd4fa185 · 2024-05-01T11:48:13.000+01:00
diff --git a/Python/optimizer_symbols.c b/Python/optimizer_symbols.c
@@ -164,12 +164,15 @@ _Py_uop_sym_set_const(_Py_UopsSymbol *sym, PyObject *const_val)
     return true;
 }
 
-
 bool
 _Py_uop_sym_set_null(_Py_UopsSymbol *sym)
 {
+    if (_Py_uop_sym_is_not_null(sym)) {
+        sym_set_bottom(sym);
+        return false;
+    }
     sym_set_flag(sym, IS_NULL);
-    return !_Py_uop_sym_is_bottom(sym);
+    return true;
 }
 
 bool

Original file line number	Diff line number	Diff line change
`@@ -164,12 +164,15 @@ _Py_uop_sym_set_const(_Py_UopsSymbol sym, PyObject const_val)`
`164`	`164`	`return true;`
`165`	`165`	`}`
`166`	`166`
`167`		`-`
`168`	`167`	`bool`
`169`	`168`	`_Py_uop_sym_set_null(_Py_UopsSymbol *sym)`
`170`	`169`	`{`
	`170`	`+ if (_Py_uop_sym_is_not_null(sym)) {`
	`171`	`+ sym_set_bottom(sym);`
	`172`	`+ return false;`
	`173`	`+ }`
`171`	`174`	`sym_set_flag(sym, IS_NULL);`
`172`		`- return !_Py_uop_sym_is_bottom(sym);`
	`175`	`+ return true;`
`173`	`176`	`}`
`174`	`177`
`175`	`178`	`bool`