unpack_iterable(): Add a missing DECREF in an error case. Reported by

gvanrossum · gvanrossum · commit bb8f59a37148 · 2001-12-03T19:33:25.000Z
Armin Rigo (SF bug #488477).  Added a testcase to test_unpack_iter()
in test_iter.py.
diff --git a/Lib/test/test_iter.py b/Lib/test/test_iter.py
@@ -747,6 +747,29 @@ def test_unpack_iter(self):
         (a, b), (c,) = IteratingSequenceClass(2), {42: 24}
         self.assertEqual((a, b, c), (0, 1, 42))
 
+        # Test reference count behavior
+
+        class C(object):
+            count = 0
+            def __new__(cls):
+                cls.count += 1
+                return object.__new__(cls)
+            def __del__(self):
+                cls = self.__class__
+                assert cls.count > 0
+                cls.count -= 1
+        x = C()
+        self.assertEqual(C.count, 1)
+        del x
+        self.assertEqual(C.count, 0)
+        l = [C(), C(), C()]
+        self.assertEqual(C.count, 3)
+        try:
+            a, b = iter(l)
+        except ValueError:
+            pass
+        del l
+        self.assertEqual(C.count, 0)
 
 def test_main():
     run_unittest(TestCase)
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -2796,6 +2796,7 @@ unpack_iterable(PyObject *v, int argcnt, PyObject **sp)
 		Py_DECREF(it);
 		return 1;
 	}
+	Py_DECREF(w);
 	PyErr_SetString(PyExc_ValueError, "too many values to unpack");
 	/* fall through */
 Error:

Original file line number	Diff line number	Diff line change
`@@ -2796,6 +2796,7 @@ unpack_iterable(PyObject v, int argcnt, PyObject *sp)`
`2796`	`2796`	`Py_DECREF(it);`
`2797`	`2797`	`return 1;`
`2798`	`2798`	`}`
	`2799`	`+ Py_DECREF(w);`
`2799`	`2800`	`PyErr_SetString(PyExc_ValueError, "too many values to unpack");`
`2800`	`2801`	`/* fall through */`
`2801`	`2802`	`Error:`