Issue #12451: xml.dom.pulldom: parse() now opens files in binary mode instead

Victor Stinner · Victor Stinner · commit bbdc08ea6e5d · 2011-07-04T01:25:55.000+02:00
of the text mode (using the locale encoding) to avoid encoding issues.
diff --git a/Lib/xml/dom/pulldom.py b/Lib/xml/dom/pulldom.py
@@ -326,7 +326,7 @@ def parse(stream_or_string, parser=None, bufsize=None):
     if bufsize is None:
         bufsize = default_bufsize
     if isinstance(stream_or_string, str):
-        stream = open(stream_or_string)
+        stream = open(stream_or_string, 'rb')
     else:
         stream = stream_or_string
     if not parser:
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -19,6 +19,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #12451: xml.dom.pulldom: parse() now opens files in binary mode instead
+  of the text mode (using the locale encoding) to avoid encoding issues.
+
 C-API
 -----
 
