In collect_children(), put a try-except around os.waitpid() because it

gvanrossum · gvanrossum · commit bfadac00ef54 · 1999-06-17T15:41:33.000Z
may raise an exception (when there are no children).  Reported by
Andy Dustman.
diff --git a/Lib/SocketServer.py b/Lib/SocketServer.py
@@ -285,7 +285,10 @@ class ForkingMixIn:
     def collect_children(self):
         """Internal routine to wait for died children."""
         while self.active_children:
-            pid, status = os.waitpid(0, os.WNOHANG)
+            try:
+                pid, status = os.waitpid(0, os.WNOHANG)
+            except os.error:
+                pid = None
             if not pid: break
             self.active_children.remove(pid)
 
