Issue #27703: Got rid of unnecessary NULL checks in do_raise() in release mode.

serhiy-storchaka · serhiy-storchaka · commit c019158a4c7a · 2016-09-27T11:37:10.000+03:00
Patch by Xiang Zhang.
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -4245,6 +4245,9 @@ do_raise(PyObject *exc, PyObject *cause)
         goto raise_error;
     }
 
+    assert(type != NULL);
+    assert(value != NULL);
+
     if (cause) {
         PyObject *fixed_cause;
         if (PyExceptionClass_Check(cause)) {
@@ -4271,8 +4274,8 @@ do_raise(PyObject *exc, PyObject *cause)
 
     PyErr_SetObject(type, value);
     /* PyErr_SetObject incref's its arguments */
-    Py_XDECREF(value);
-    Py_XDECREF(type);
+    Py_DECREF(value);
+    Py_DECREF(type);
     return 0;
 
 raise_error:
