Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit c1890e6

Browse files
[3.12] gh-114149: [Enum] fix tuple subclass handling when using custom __new__ (GH-114160) (GH-114196)
(cherry picked from commit 33b47a2) Co-authored-by: Ethan Furman <[email protected]>
1 parent 24d2392 commit c1890e6

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

Lib/enum.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ def __set_name__(self, enum_class, member_name):
254254
delattr(enum_class, member_name)
255255
# second step: create member based on enum_class
256256
value = self.value
257-
if not isinstance(value, tuple):
257+
if type(value) is not tuple:
258258
args = (value, )
259259
else:
260260
args = value
@@ -1757,7 +1757,7 @@ def convert_class(cls):
17571757
else:
17581758
# create the member
17591759
if use_args:
1760-
if not isinstance(value, tuple):
1760+
if type(value) is not tuple:
17611761
value = (value, )
17621762
member = new_member(enum_class, *value)
17631763
value = value[0]
@@ -1807,7 +1807,7 @@ def convert_class(cls):
18071807
else:
18081808
# create the member
18091809
if use_args:
1810-
if not isinstance(value, tuple):
1810+
if type(value) is not tuple:
18111811
value = (value, )
18121812
member = new_member(enum_class, *value)
18131813
value = value[0]

Lib/test/test_enum.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3163,6 +3163,22 @@ class NTEnum(Enum):
31633163
[x.value for x in NTEnum],
31643164
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
31653165
)
3166+
#
3167+
class NTDEnum(Enum):
3168+
def __new__(cls, t_value):
3169+
member = object.__new__(cls)
3170+
member._value_ = t_value[0]
3171+
member.id = t_value[0]
3172+
member.a = t_value[1]
3173+
member.blist = t_value[2]
3174+
return member
3175+
NONE = TTuple(0, 0, [])
3176+
A = TTuple(1, 2, [4])
3177+
B = TTuple(2, 4, [0, 1, 2])
3178+
self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: 0>")
3179+
self.assertEqual(NTDEnum.NONE.id, 0)
3180+
self.assertEqual(NTDEnum.A.a, 2)
3181+
self.assertEqual(NTDEnum.B.blist, [0, 1 ,2])
31663182

31673183
def test_flag_with_custom_new(self):
31683184
class FlagFromChar(IntFlag):
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Enum: correctly handle tuple subclasses in custom ``__new__``.

0 commit comments

Comments
 (0)