Issue #18408: Oh, I was wrong: Pickler_New() must call Py_DECREF() to destroy

vstinner · vstinner · commit c31df042340e · 2013-07-12T00:08:59.000+02:00
the newly created pickler, and not PyObject_GC_Del().
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -782,7 +782,7 @@ _Pickler_New(void)
                                                     self->max_output_len);
 
     if (self->memo == NULL || self->output_buffer == NULL) {
-        PyObject_GC_Del(self);
+        Py_DECREF(self);
         return NULL;
     }
     return self;

Original file line number	Diff line number	Diff line change
`@@ -782,7 +782,7 @@ _Pickler_New(void)`
`782`	`782`	`self->max_output_len);`
`783`	`783`
`784`	`784`	`if (self->memo == NULL \|\| self->output_buffer == NULL) {`
`785`		`- PyObject_GC_Del(self);`
	`785`	`+ Py_DECREF(self);`
`786`	`786`	`return NULL;`
`787`	`787`	`}`
`788`	`788`	`return self;`