Charles G Waldman: Doing a PyObject_New then PyMem_DEL causes havoc if

gvanrossum · gvanrossum · commit c4428c58bba8 · 2000-04-25T15:59:32.000Z
you are trying to use Py_TRACE_REFS.
diff --git a/Modules/pcremodule.c b/Modules/pcremodule.c
@@ -204,7 +204,7 @@ PyPcre_compile(self, args)
 				 &error, &erroroffset, dictionary);
 	if (rv->regex==NULL) 
 	{
-		PyMem_DEL(rv);
+		Py_DECREF(rv);
 		if (!PyErr_Occurred())
 		{
 			PyObject *errval = Py_BuildValue("si", error, erroroffset);
@@ -217,7 +217,7 @@ PyPcre_compile(self, args)
 	if (rv->regex_extra==NULL && error!=NULL) 
 	{
 		PyObject *errval = Py_BuildValue("si", error, 0);
-		PyMem_DEL(rv);
+		Py_DECREF(rv);
 		PyErr_SetObject(ErrorObject, errval);
 		Py_XDECREF(errval);
 		return NULL;
@@ -228,7 +228,7 @@ PyPcre_compile(self, args)
 		PyObject *errval = Py_BuildValue("si", error, rv->num_groups);
 		PyErr_SetObject(ErrorObject, errval);
 		Py_XDECREF(errval);
-		PyMem_DEL(rv);
+		Py_DECREF(rv);
 		return NULL;
 	}
 	return (PyObject *)rv;
