Use PyModule_AddObjectRef

tiran · tiran · commit c620a616514e · 2020-11-19T08:51:21.000+01:00
diff --git a/Modules/_queuemodule.c b/Modules/_queuemodule.c
@@ -385,17 +385,15 @@ static int
 queuemodule_exec(PyObject *module)
 {
     simplequeue_state *state = simplequeue_get_state(module);
+
     state->EmptyError = PyErr_NewExceptionWithDoc(
         "_queue.Empty",
         "Exception raised by Queue.get(block=0)/get_nowait().",
         NULL, NULL);
     if (state->EmptyError == NULL) {
         return -1;
     }
-
-    Py_INCREF(state->EmptyError);
-    if (PyModule_AddObject(module, "Empty", state->EmptyError) < 0) {
-        Py_CLEAR(state->EmptyError);
+    if (PyModule_AddObjectRef(module, "Empty", state->EmptyError) < 0) {
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -385,17 +385,15 @@ static int`
`385`	`385`	`queuemodule_exec(PyObject *module)`
`386`	`386`	`{`
`387`	`387`	`simplequeue_state *state = simplequeue_get_state(module);`
	`388`	`+`
`388`	`389`	`state->EmptyError = PyErr_NewExceptionWithDoc(`
`389`	`390`	`"_queue.Empty",`
`390`	`391`	`"Exception raised by Queue.get(block=0)/get_nowait().",`
`391`	`392`	`NULL, NULL);`
`392`	`393`	`if (state->EmptyError == NULL) {`
`393`	`394`	`return -1;`
`394`	`395`	`}`
`395`		`-`
`396`		`- Py_INCREF(state->EmptyError);`
`397`		`- if (PyModule_AddObject(module, "Empty", state->EmptyError) < 0) {`
`398`		`- Py_CLEAR(state->EmptyError);`
	`396`	`+ if (PyModule_AddObjectRef(module, "Empty", state->EmptyError) < 0) {`
`399`	`397`	`return -1;`
`400`	`398`	`}`
`401`	`399`