Raise ValueError when attempting to set the _CHUNK_SIZE attribute of a TextIOWrapper to a huge value, not TypeError.

pitrou · pitrou · commit cb4ae815b5db · 2011-07-13T21:07:49.000+02:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -27,6 +27,9 @@ Core and Builtins
 Library
 -------
 
+- Raise ValueError when attempting to set the _CHUNK_SIZE attribute of a
+  TextIOWrapper to a huge value, not TypeError.
+
 - Issue #12493: subprocess: Popen.communicate() now also handles EINTR errors
   if the process has only one pipe.
 
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
@@ -2556,7 +2556,7 @@ textiowrapper_chunk_size_set(textio *self, PyObject *arg, void *context)
 {
     Py_ssize_t n;
     CHECK_INITIALIZED_INT(self);
-    n = PyNumber_AsSsize_t(arg, PyExc_TypeError);
+    n = PyNumber_AsSsize_t(arg, PyExc_ValueError);
     if (n == -1 && PyErr_Occurred())
         return -1;
     if (n <= 0) {

Original file line number	Diff line number	Diff line change
`@@ -2556,7 +2556,7 @@ textiowrapper_chunk_size_set(textio self, PyObject arg, void *context)`
`2556`	`2556`	`{`
`2557`	`2557`	`Py_ssize_t n;`
`2558`	`2558`	`CHECK_INITIALIZED_INT(self);`
`2559`		`- n = PyNumber_AsSsize_t(arg, PyExc_TypeError);`
	`2559`	`+ n = PyNumber_AsSsize_t(arg, PyExc_ValueError);`
`2560`	`2560`	`if (n == -1 && PyErr_Occurred())`
`2561`	`2561`	`return -1;`
`2562`	`2562`	`if (n <= 0) {`