Handle really big steps in extended slices.

Michael W. Hudson · Michael W. Hudson · commit cbd6fb90069d · 2002-11-06T15:17:32.000Z
Fixes a test failure on 64 bit platforms (I hope).
diff --git a/Objects/sliceobject.c b/Objects/sliceobject.c
@@ -121,11 +121,8 @@ PySlice_GetIndicesEx(PySliceObject *r, int length,
 		*step = 1;
 	} 
 	else {
-		*step = PyInt_AsLong(r->step);
-		if (*step == -1 && PyErr_Occurred()) {
-			return -1;
-		}
-		else if (*step == 0) {
+		if (!_PyEval_SliceIndex(r->step, step)) return -1;
+		if (*step == 0) {
 			PyErr_SetString(PyExc_ValueError,
 					"slice step cannot be zero");
 			return -1;
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -3507,7 +3507,7 @@ _PyEval_SliceIndex(PyObject *v, int *pi)
 		if (x > INT_MAX)
 			x = INT_MAX;
 		else if (x < -INT_MAX)
-			x = 0;
+			x = -INT_MAX;
 		*pi = x;
 	}
 	return 1;

Original file line number	Diff line number	Diff line change
`@@ -3507,7 +3507,7 @@ _PyEval_SliceIndex(PyObject v, int pi)`
`3507`	`3507`	`if (x > INT_MAX)`
`3508`	`3508`	`x = INT_MAX;`
`3509`	`3509`	`else if (x < -INT_MAX)`
`3510`		`- x = 0;`
	`3510`	`+ x = -INT_MAX;`
`3511`	`3511`	`*pi = x;`
`3512`	`3512`	`}`
`3513`	`3513`	`return 1;`